[FIX] l10n_ar_tax: fix payment_total computation with withholding#1186
Open
cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
Open
[FIX] l10n_ar_tax: fix payment_total computation with withholding#1186cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
|
|
Added a condition to consider the payment_type when computing the payment_total field in account.payment, to avoid adding the withholding amount twice when the payment is of type 'outbound'.
cav-adhoc
force-pushed
the
18.0-h-98310-cav
branch
from
ef2d214 to
4003d02
Compare
cav-adhoc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the withholding amounts are always added as positive values in the payment total calculation by updating the logic in
AccountPayment._compute_payment_total. This fixes the use case where a customer payment is in send and the withholding amounts were negative.